Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/bump packages and Ember to 3.24 #5

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .bowerrc

This file was deleted.

8 changes: 4 additions & 4 deletions addon/controller.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Ember from 'ember';
import Controller from "@ember/controller";

export default Ember.Controller.extend({
url: null
});
export default class HellgateController extends Controller {
url = null;
}
48 changes: 31 additions & 17 deletions addon/setup.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
import Ember from 'ember';
import HellgateController from './controller';
import Ember from "ember";
import EmberRouter from "@ember/routing/router";
import { getOwner } from "@ember/application";
import { dasherize } from "@ember/string";
import { run } from "@ember/runloop";
import HellgateController from "./controller";
import template from "ember-hellgate/templates/view";
import getOwner from 'ember-getowner-polyfill';

const {Router, RouterDSL, String, run} = Ember;
const { RouterDSL } = Ember;

const dasherize = String.dasherize;

let gates = [];
const gates = [];

function canNest(dsl) {
return dsl.parent && dsl.parent !== 'application';
return dsl.parent && dsl.parent !== "application";
}

function getFullName(dsl, name, resetNamespace) {
Expand All @@ -21,25 +22,38 @@ function getFullName(dsl, name, resetNamespace) {
}
}

function setupHellgate() {
RouterDSL.prototype.hellgate = function(name, url, options = {}) {
if (!name || !url) { throw new Error("You must provide at least a name and URL to `hellgate`."); }
const setupHellgate = () => {
RouterDSL.prototype.hellgate = function (name, url, options = {}) {
if (!name || !url) {
throw new Error(
"You must provide at least a name and URL to `hellgate`."
);
}

this.route(name, options);

let fullName = getFullName(this, name, options.resetNamespace);
const fullName = getFullName(this, name, options.resetNamespace);
gates.push([fullName, url]);
};

Router.reopen({
EmberRouter.reopen({
setupRouter() {
const ret = this._super(...arguments);
const owner = getOwner(this);

gates.forEach(([fullName, url]) => {
let moduleName = dasherize(fullName);
const moduleName = dasherize(fullName);
const gateAlreadyExists = owner.lookup(`template:${moduleName}`);

if (gateAlreadyExists) {
return;
}

const Controller = class extends HellgateController {
url = url;
};
owner.register(`template:${moduleName}`, template);
owner.register(`controller:${moduleName}`, HellgateController.extend({url: url}));
owner.register(`controller:${moduleName}`, Controller);
});

window.escapeHell = (...args) => {
Expand All @@ -49,8 +63,8 @@ function setupHellgate() {
};

return ret;
}
},
});
}
};

export default setupHellgate;
4 changes: 2 additions & 2 deletions addon/templates/view.hbs
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<div class="hellgate-container">
<iframe src={{url}} class="hellgate-iframe"></iframe>
</div>
<iframe src={{this.url}} class="hellgate-iframe"></iframe>
</div>
10 changes: 4 additions & 6 deletions app/initializers/hellgate.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import setupHellgate from 'ember-hellgate/setup';
import setupHellgate from "ember-hellgate/setup";

setupHellgate();

export function initialize(application) {

}
export function initialize(application) {}

export default {
name: 'ember-hellgate',
initialize
name: "ember-hellgate",
initialize,
};
9 changes: 0 additions & 9 deletions bower.json

This file was deleted.

50 changes: 25 additions & 25 deletions config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,54 +2,54 @@
module.exports = {
scenarios: [
{
name: 'default',
name: "default",
bower: {
dependencies: { }
}
dependencies: {},
},
},
{
name: 'ember-1-13',
name: "ember-3-16",
bower: {
dependencies: {
'ember': '~1.13.0'
ember: "~3.16.0",
},
resolutions: {
'ember': '~1.13.0'
}
}
ember: "~3.16.0",
},
},
},
{
name: 'ember-release',
name: "ember-release",
bower: {
dependencies: {
'ember': 'components/ember#release'
ember: "components/ember#release",
},
resolutions: {
'ember': 'release'
}
}
ember: "release",
},
},
},
{
name: 'ember-beta',
name: "ember-beta",
bower: {
dependencies: {
'ember': 'components/ember#beta'
ember: "components/ember#beta",
},
resolutions: {
'ember': 'beta'
}
}
ember: "beta",
},
},
},
{
name: 'ember-canary',
name: "ember-canary",
bower: {
dependencies: {
'ember': 'components/ember#canary'
ember: "components/ember#canary",
},
resolutions: {
'ember': 'canary'
}
}
}
]
ember: "canary",
},
},
},
],
};
14 changes: 9 additions & 5 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
/* jshint node: true */
'use strict';
"use strict";

module.exports = {
name: 'ember-hellgate',
name: "ember-hellgate",

included: function(app) {
app.import('vendor/ember-hellgate.css');
}
included(app, parentAddon) {
let target = parentAddon || app;
target.options = target.options || {};
target.options.babel = target.options.babel || { includePolyfill: true };
target.import("vendor/ember-hellgate.css");
return this._super.included.apply(this, arguments);
},
};
Loading