WIP: Fix up codegen #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc2332
requested changes
Jul 15, 2024
| let (fill, stroke, stroke_width) = props.icon.fill_and_stroke(&props.fill); | ||
|
|
||
| let id = props.id.unwrap_or_default(); | ||
| let width = if props.width == 0 { props.icon.width() } else { &props.width.to_string() }; |
There was a problem hiding this comment.
Suggested change
| let width = if props.width == 0 { props.icon.width() } else { &props.width.to_string() }; | |
| let width = props.icon.width().unwrap_or(props.width); |
Comment on lines
+32
to
33
| #[props(default = 0)] | ||
| pub width: u32, |
There was a problem hiding this comment.
Suggested change
| #[props(default = 0)] | |
| pub width: u32, | |
| pub width: Option<u32>, |
There was a problem hiding this comment.
Would it be worth changing width and height input to String to allow for unit identifiers? Or even implement it as an Enum?
| @@ -18,18 +15,33 @@ impl IconShape for {ICON_NAME} { | |||
| fn view_box(&self) -> &str { | |||
| "{VIEW_BOX}" | |||
| } | |||
| fn width(&self) -> &str { | |||
There was a problem hiding this comment.
Suggested change
| fn width(&self) -> &str { | |
| fn width(&self) -> u32{ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to have a crack at fixing up the codegen a bit, getting rid of hard-coded values.
Values like width, height, fill, stroke, stroke-width, stroke-linecap, stroke-linejoin etc are now fetched from attributes instead of essentially being hard-coded values.
Also made some changes to the Icon struct to take options for some values instead of hard-coded string defaults so we can dynamically choose between user-input and icon defaults.
The svg parsing could do with being reworked to support svg's which have more than one parent element. Maybe in the future could add support for new features/attributes.