Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icons to latest versions #61

Closed

Conversation

hyziri
Copy link

@hyziri hyziri commented Dec 1, 2024

Added Font Awesome Bluesky icon to fa_brands_icons

@marc2332
Copy link
Member

marc2332 commented Dec 1, 2024

The icons are generated automatically, did you run the codegen or did you just add the icon?

@marc2332 marc2332 added the enhancement New feature or request label Dec 1, 2024
@hyziri
Copy link
Author

hyziri commented Dec 2, 2024

I added it manually, reading the README more thoroughly I see the part about the codegen now. I'll look into running it tomorrow, anything I should know prior to using it considering I've never used a codegen for an icon library before?

@hyziri hyziri changed the title Add Font Awesome Brands Bluesky Icon Update icons to latest versions Dec 3, 2024
@hyziri
Copy link
Author

hyziri commented Dec 3, 2024

Replaced the commit adding the Bluesky icon instead with a commit updating all icons to their latest versions using the codegen as instructed in the README.md.

  • Updated all icons to latest versions using the codegen
  • Fixed a typo in packages/codegen/src/main.rs that stated // create feather icons instead of // create lucide icons
  • README.md has been updated with links to the updated icon repositories & licenses where applicable.

If there are any issues please let me know.

Copy link
Member

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyziri
Copy link
Author

hyziri commented Dec 4, 2024

Looks like heroicons changed their src folder format between versions v1.0.6 and v2.2.0. I've reverted the heroicons source I was using back to v1.0.6 which has solved the issue. I'll let someone else implement the new version of heroicons when they need it.

Let me know if there are any further issues.

@marc2332 marc2332 deleted the branch dioxus-community:feat/dioxus-0.6 December 10, 2024 09:46
@marc2332 marc2332 closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants