-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Adds Iñigo's Community Bonding Period Blog #36
Conversation
🪓 PR closed, deleted preview at https://github.com/dipy/preview-html/tree/main/dipy.org/pull/36/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the codespell error.
Looks good besides the inline comment.
Thanks.
PR looks good to me, codespell issue happening due to previous blog post. I am not sure if we should correct it or not. |
overall, it looks ok, but the first blog post is slightly different than the others look at
And update with those inspiration |
LGTM! I'll push my blogs to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @itellaetxe , overall it looks good. See below for my comments.
Thank you for addressing them
@skoudoro, I do not see any warnings now in the CI. I think it is ready to merge. I will go and post it in the Mastodon server once you merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was waiting for the review of @WassCodeur, but ok, I will go ahead and merge it. all good.
Thank you for this!
[DOC] Adds Iñigo's Community Bonding Period Blog 48a18b6
Changes
/blogs/2024
directory for this year's GSoC blogs. Other GSoC mates can push their blogs to this folder.@deka27 @WassCodeur @robinroy03