Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Adds Iñigo's Community Bonding Period Blog #36

Merged
merged 5 commits into from
May 29, 2024

Conversation

itellaetxe
Copy link
Contributor

@itellaetxe itellaetxe commented May 27, 2024

Changes

  • Added /blogs/2024 directory for this year's GSoC blogs. Other GSoC mates can push their blogs to this folder.
  • Added my community bonding period blog.

@deka27 @WassCodeur @robinroy03

Copy link
Contributor

github-actions bot commented May 27, 2024

🪓 PR closed, deleted preview at https://github.com/dipy/preview-html/tree/main/dipy.org/pull/36/

Copy link
Contributor

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the codespell error.

Looks good besides the inline comment.

Thanks.

posts/2024/2024_05_27_Inigo_week_0.rst Show resolved Hide resolved
@deka27
Copy link
Member

deka27 commented May 28, 2024

PR looks good to me, codespell issue happening due to previous blog post. I am not sure if we should correct it or not.

@skoudoro
Copy link
Member

overall, it looks ok, but the first blog post is slightly different than the others

look at

And update with those inspiration

@itellaetxe
Copy link
Contributor Author

@deka27 I also corrected the codespell errors, same as you did in your PR, so we don't have to rebase. Thanks for pointing that out.
@skoudoro I think it looks better now, more aligned with the inspo you suggested. Thanks

@robinroy03
Copy link
Member

LGTM!
I also had some trouble with dockerfile, good to know I'm not alone :)

I'll push my blogs to fury/docs/source/posts/2024.

Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @itellaetxe , overall it looks good. See below for my comments.

Thank you for addressing them

posts/2024/2024_05_27_Inigo_week_0.rst Outdated Show resolved Hide resolved
posts/2024/2024_05_27_Inigo_week_0.rst Outdated Show resolved Hide resolved
posts/2024/2024_05_27_Inigo_week_0.rst Outdated Show resolved Hide resolved
posts/2024/2024_05_27_Inigo_week_0.rst Outdated Show resolved Hide resolved
posts/2024/2024_05_27_Inigo_week_0.rst Outdated Show resolved Hide resolved
@itellaetxe
Copy link
Contributor Author

@skoudoro, I do not see any warnings now in the CI. I think it is ready to merge. I will go and post it in the Mastodon server once you merge it.

Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was waiting for the review of @WassCodeur, but ok, I will go ahead and merge it. all good.

Thank you for this!

@skoudoro skoudoro merged commit 48a18b6 into dipy:master May 29, 2024
3 checks passed
github-actions bot added a commit that referenced this pull request May 29, 2024
[DOC] Adds Iñigo's Community Bonding Period Blog 48a18b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants