Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Blogpost_KD_Week1 #38

Merged
merged 1 commit into from
Jun 6, 2024
Merged

DOC: Blogpost_KD_Week1 #38

merged 1 commit into from
Jun 6, 2024

Conversation

deka27
Copy link
Member

@deka27 deka27 commented Jun 3, 2024

Summary:
This pull request introduces a blog post for the 2nd week of GSOC. It aims to provide insights and reflections for future work as well.

Key Changes:

  • Added a new blog post file in the posts/2024 directory.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

🪓 PR closed, deleted preview at https://github.com/dipy/preview-html/tree/main/dipy.org/pull/38/

@deka27
Copy link
Member Author

deka27 commented Jun 3, 2024

I can squash the commits after any changes are required from feedback.

Copy link
Contributor

@itellaetxe itellaetxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a good start!
Only a small grammar issue, and a couple of title separator length issues.
Other than that, LGTM. Approving if you correct that.

--------------------------------------

Building upon the foundation laid during the Community Bonding period, I have been looking into the expansion of the decorator implementation across more modules in DIPY.
I am have gone through the required functions and tests. I will have to plan which modules are next for change with my mentor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am have gone --> I have gone

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Thanks.

I will write comprehensive tests in this part as well. Also will be updating the necessary documentation as well.

Refining Decorator Implementation
--------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will give warnings, one more "-" is needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thank you.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly in my local, the amount is correct but in github it shows 1 less. I will add 1 more either ways.

I will continue to refine the decorator implementation based on feedback from the community and my mentor. This includes fixing any bugs, improving performance, and enhancing the documentation further.

Lazy Loading Integration
--------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Match the title length with the section separator length. In this case, too many "-".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted.

@@ -0,0 +1,49 @@
My Journey Continues: Week 2 Progress with DIPY
===============================================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Week 2 ? week 1 I believe. your filename is week 1, and the previous week was week 0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, Changed.

In addition to expanding the decorator implementation, I have begun researching for Task 2, which involves integrating lazy loading into DIPY. Lazy loading is a design pattern that can help improve the efficiency and performance of the codebase by delaying the initialization of objects until they are actually needed.
I will begin this task when my mentor will advise me to.

Community Engagement:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colon not needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@robinroy03 robinroy03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@WassCodeur WassCodeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Great job👍

@skoudoro skoudoro merged commit c9c62a4 into dipy:master Jun 6, 2024
3 checks passed
github-actions bot added a commit that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants