-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Blogpost_KD_Week1 #38
Conversation
🪓 PR closed, deleted preview at https://github.com/dipy/preview-html/tree/main/dipy.org/pull/38/ |
I can squash the commits after any changes are required from feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a good start!
Only a small grammar issue, and a couple of title separator length issues.
Other than that, LGTM. Approving if you correct that.
-------------------------------------- | ||
|
||
Building upon the foundation laid during the Community Bonding period, I have been looking into the expansion of the decorator implementation across more modules in DIPY. | ||
I am have gone through the required functions and tests. I will have to plan which modules are next for change with my mentor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am have gone
--> I have gone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. Thanks.
I will write comprehensive tests in this part as well. Also will be updating the necessary documentation as well. | ||
|
||
Refining Decorator Implementation | ||
-------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will give warnings, one more "-" is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weirdly in my local, the amount is correct but in github it shows 1 less. I will add 1 more either ways.
I will continue to refine the decorator implementation based on feedback from the community and my mentor. This includes fixing any bugs, improving performance, and enhancing the documentation further. | ||
|
||
Lazy Loading Integration | ||
-------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Match the title length with the section separator length. In this case, too many "-".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted.
@@ -0,0 +1,49 @@ | |||
My Journey Continues: Week 2 Progress with DIPY | |||
=============================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Week 2 ? week 1 I believe. your filename is week 1, and the previous week was week 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, Changed.
In addition to expanding the decorator implementation, I have begun researching for Task 2, which involves integrating lazy loading into DIPY. Lazy loading is a design pattern that can help improve the efficiency and performance of the codebase by delaying the initialization of objects until they are actually needed. | ||
I will begin this task when my mentor will advise me to. | ||
|
||
Community Engagement: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
colon not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Great job👍
DOC: Blogpost_KD_Week1 c9c62a4
Summary:
This pull request introduces a blog post for the 2nd week of GSOC. It aims to provide insights and reflections for future work as well.
Key Changes: