-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Kaustav GSOC Final Work Product #66
Conversation
🪓 PR closed, deleted preview at https://github.com/dipy/preview-html/tree/main/dipy.org/pull/66/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kaustav, you've done an amazing work this GSoC :) The report is good and contains all the technical information. You've done good work with CSS also. I'm glad to be in the same cohort as you.
|weekly-title| | ||
-------------- | ||
|
||
- My blog posts can be found on the DIPY website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, I agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for redesign some part of it.
it looks good overall. Please, address robin comment.
I think it can be merged tomorrow
Also, waiting for the review of @itellaetxe and @WassCodeur |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kaustav, amazing job.
I like how well organized your report is, and how clear you expressed the ideas.
From my side, I have nothing to add, LGTM! Thank you for your contributions and for your help. Ready to merge in my opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. LGTM
Final Work Product
Changes Made
Reasons for Changes
Image Compatibility: Previous image links were not compatible with dark mode. By adding the images to the repository, we ensure consistent display across all color schemes.
Image Styling: A new CSS class was added to provide transparent backgrounds for images, enhancing their appearance in dark mode.
Report Aesthetics: A custom title class was implemented for the GSOC report to improve visual appeal while maintaining consistency with the website's primary color scheme.
Implementation Details
Testing
To test these changes:
Please review these changes and let me know if any adjustments are needed.