Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Kaustav GSOC Final Work Product #66

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

deka27
Copy link
Member

@deka27 deka27 commented Aug 21, 2024

Final Work Product

Changes Made

  • Added the final project report to the repository
  • Incorporated logo images directly into the repository
  • Implemented a new CSS class for images
  • Created a custom title class for the GSOC report

Reasons for Changes

  1. Image Compatibility: Previous image links were not compatible with dark mode. By adding the images to the repository, we ensure consistent display across all color schemes.

  2. Image Styling: A new CSS class was added to provide transparent backgrounds for images, enhancing their appearance in dark mode.

  3. Report Aesthetics: A custom title class was implemented for the GSOC report to improve visual appeal while maintaining consistency with the website's primary color scheme.

Implementation Details

  • Logo images are now stored locally in the repository
  • New CSS class for images includes a transparent background property
  • Custom title class utilizes the website's primary color for improved aesthetics

Testing

To test these changes:

  1. Verify that the final project report is accessible and formatted correctly
  2. Check that logo images display properly in both light and dark modes
  3. Confirm that images have transparent backgrounds
  4. Review the GSOC report to ensure the custom title styling is applied correctly

Please review these changes and let me know if any adjustments are needed.

@deka27 deka27 changed the title DOC: Final Report DOC: Kaustav GSOC Final Work Product Aug 21, 2024
Copy link
Contributor

github-actions bot commented Aug 21, 2024

🪓 PR closed, deleted preview at https://github.com/dipy/preview-html/tree/main/dipy.org/pull/66/

Copy link
Member

@robinroy03 robinroy03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kaustav, you've done an amazing work this GSoC :) The report is good and contains all the technical information. You've done good work with CSS also. I'm glad to be in the same cohort as you.

|weekly-title|
--------------

- My blog posts can be found on the DIPY website.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need this section, since you're sharing the blog posts immediately below. Also, there isn't enough content for it to be a section.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I agree

Copy link
Member

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for redesign some part of it.

it looks good overall. Please, address robin comment.

I think it can be merged tomorrow

@skoudoro
Copy link
Member

Also, waiting for the review of @itellaetxe and @WassCodeur

Copy link
Contributor

@itellaetxe itellaetxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kaustav, amazing job.

I like how well organized your report is, and how clear you expressed the ideas.

From my side, I have nothing to add, LGTM! Thank you for your contributions and for your help. Ready to merge in my opinion

Copy link
Member

@WassCodeur WassCodeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. LGTM

@skoudoro skoudoro merged commit d808db6 into dipy:master Aug 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants