Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sticker pack banner CDN path including specific application ID #7295

Closed
wants to merge 1 commit into from

Conversation

FinOCE
Copy link
Contributor

@FinOCE FinOCE commented Nov 29, 2024

Noticed this path has an actual application ID in it instead of the hyperlink to the application object. It's obvious enough what it means, but it you took it at face value you'd be trying to fetch app assets off some random bot not your own lol

@FinOCE FinOCE requested a review from a team as a code owner November 29, 2024 14:02
@FinOCE FinOCE requested review from JustinBeckwith and removed request for a team November 29, 2024 14:02
@Lulalaby
Copy link
Contributor

Iirc it was because this route is exclusive for nitro sticker packs and the banner images were saved in that specific application. Might be wrong but I remember something along these lines.

@FinOCE
Copy link
Contributor Author

FinOCE commented Nov 29, 2024

Iirc it was because this route is exclusive for nitro sticker packs and the banner images were saved in that specific application. Might be wrong but I remember something along these lines.

Ah that's funny. A note somewhere mentioning that would be nice but I'll close the PR :)

@FinOCE FinOCE closed this Nov 29, 2024
@FinOCE FinOCE deleted the fix-cdn-path branch November 29, 2024 14:32
@Lulalaby
Copy link
Contributor

Yeah, GET https://canary.discord.com/api/v10/applications/710982414301790216/rpc shows

{
	"id": "710982414301790216",
	"name": "Stickers",
	"icon": null,
	"description": "",
	"summary": "",
	"type": null,
	"is_monetized": false,
	"is_verified": false,
	"is_discoverable": false,
	"hook": true,
	"storefront_available": false,
	"integration_types_config": {
		"0": {}
	},
	"verify_key": "4be0b338ea2e6b55ca654be7d08534b99260888d08b7f2636cca1a962a5cd21b",
	"flags": 0
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants