Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use git-derived version in container image #422

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mogyuchi
Copy link
Collaborator

@Mogyuchi Mogyuchi commented Jun 5, 2024

gitオブジェクトに基づくバージョンを使うようにします。
これにより、edgeイメージなどにおけるバージョン表示の情報量を増やします。

@Mogyuchi Mogyuchi self-assigned this Jun 5, 2024
@Mogyuchi Mogyuchi force-pushed the git-derived-version branch from be0a8f1 to 91b3d8e Compare June 5, 2024 10:51
@Mogyuchi Mogyuchi force-pushed the git-derived-version branch from 91b3d8e to 5528e65 Compare June 5, 2024 10:55
@Mogyuchi Mogyuchi marked this pull request as ready for review June 5, 2024 11:01
@Mogyuchi Mogyuchi requested a review from cm-ayf June 5, 2024 11:07
.github/workflows/docker-publish.yml Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
.github/workflows/docker-publish.yml Show resolved Hide resolved
@Mogyuchi Mogyuchi marked this pull request as draft June 6, 2024 17:46
@cm-ayf
Copy link
Collaborator

cm-ayf commented Jun 8, 2024

package.jsonのversionプロパティをいじるのは良くないのでは?ということで別の方法を模索中

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants