Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dotenv #6

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Add dotenv #6

merged 2 commits into from
Oct 27, 2023

Conversation

phenylshima
Copy link
Contributor

Depends on: #5

@phenylshima phenylshima marked this pull request as ready for review October 20, 2023 23:13
@cm-ayf
Copy link
Collaborator

cm-ayf commented Oct 21, 2023

#5 merged

@mouse484 mouse484 self-requested a review October 22, 2023 00:24
mouse484
mouse484 requested changes Oct 22, 2023
View reviewed changes
Copy link
Member

@mouse484 mouse484 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node 20系のLTSが10月24日から始まるのでnodeバージョンを20にして組み込みの.env使いませんか？

https://nodejs.org/ja/blog/release/v20.6.0#built-in-env-file-support

@phenylshima
Copy link
Contributor Author

phenylshima commented Oct 22, 2023 •
edited
Loading

現時点で@discordjs/opusがNode 20に対応していないため，残念ながら当面は18を使うことになりそうです．

@mouse484 mouse484 requested review from mouse484 and removed request for mouse484 October 24, 2023 06:19
@cm-ayf cm-ayf merged commit 9bd5ccd into discordjs-japan:main Oct 27, 2023
1 check passed
@phenylshima phenylshima deleted the dotenv branch October 27, 2023 04:29
@phenylshima phenylshima mentioned this pull request Oct 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mouse484 mouse484 mouse484 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phenylshima @cm-ayf @mouse484