Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(APIEntitlement): update ends_at and starts_at to be nullable #1158

Merged

Conversation

sdanialraza
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 8:47pm

@Jiralite Jiralite changed the title chore(APIEntitlement): update ends_at and starts_at to be nullable refactor(APIEntitlement): update ends_at and starts_at to be nullable Nov 26, 2024
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not present when using test entitlements.

This needs to be amended too!

@sdanialraza sdanialraza force-pushed the chore/update-ends_at-starts_at-nullable branch from 77f65cd to b8a123c Compare December 2, 2024 20:39
@sdanialraza sdanialraza marked this pull request as ready for review December 2, 2024 20:40
@sdanialraza sdanialraza requested review from a team as code owners December 2, 2024 20:40
@almeidx almeidx merged commit 68e19d3 into discordjs:main Dec 5, 2024
5 checks passed
@sdanialraza sdanialraza deleted the chore/update-ends_at-starts_at-nullable branch December 5, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants