Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pagination): ButtonOptions string emoji #1084

Merged

Conversation

DemonWayne
Copy link
Contributor

Please describe the changes this PR makes:
Added ability to specify button emoji in string format for pagination ButtonOptions.

@vijayymmeena
Copy link
Member

@DemonWayne please sign the commit https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

You can also edit the file on GitHub to sign commits. I checked, and we can replace the type with ComponentEmojiResolvable from discord.js, which would be a better option. Could you please make that change? Thank you!

@vijayymmeena
Copy link
Member

@DemonWayne You need to remove your first unverified commit. I've enabled verified commits on the main branch, which is preventing me from merging.

@vijayymmeena
Copy link
Member

git reset --soft origin/main

and then commit again.

vijayymmeena
vijayymmeena previously approved these changes Feb 19, 2025
Copy link

@Codixer Codixer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I approve :)

@vijayymmeena vijayymmeena force-pushed the feat/pagination-string-button-emoji branch from 7dc7017 to a7d9c0a Compare February 19, 2025 18:12
@vijayymmeena
Copy link
Member

@DemonWayne I had to rewrite commit history for merge and patch release. Thank your for your work. Upon merge, patch will be released.

Thank you

@vijayymmeena vijayymmeena merged commit 1a6cc82 into discordx-ts:main Feb 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants