REFACTOR: convert to ember component, add timeline toggle #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janzenisaac
force-pushed
the
ember-refactor
branch
from
29a3126 to
deb74b4
Compare
janzenisaac
approved these changes
Jan 10, 2024
awesomerobot
changed the title
janzenisaac
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the TOC component to a modern Ember component, moving away from the original version which largely relied on direct DOM manipulation using vanilla JS in the initializer.
In addition it adds a toggle so users can switch between the table of contents and the topic timeline.
The acceptance tests have been replaced with system specs.
This update will require Discourse 3.2.0.beta5-dev or later, due to the reliance on some new plugin outlet arguments. The Discourse Docs plugin will also require updating to be compatible.