DEV: merge discourse post event settings to calendar #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, site settings were divided into `discourse calendar` and `discourse events`. This PR is merging them. Also, translation were moved under `discourse_calendar` key.
| @@ -305,148 +305,148 @@ en: | |||
| week: "Week" | |||
| day: "Day" | |||
| list: "List" | |||
| discourse_post_event: | |||
There was a problem hiding this comment.
Sorry to move even more cheese here...but can we also change instances of discourse_post_event to discourse_events? I've never understood why it was called that...
There was a problem hiding this comment.
If it's too hard to do all in one go that's fine.
| @@ -62,33 +62,33 @@ en: | |||
| event_expired: "Event expired" | |||
| holiday_status: | |||
| description: "On holiday" | |||
| discourse_post_event: | |||
There was a problem hiding this comment.
Same comment about discourse_post_event here
martin-brennan
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, site settings were divided into
discourse calendaranddiscourse events.This PR is merging them. Also, translation were moved under
discourse_calendarkey.