UX: Render invitees count #663
Conversation
| <DButton | ||
| class="show-all btn-small" | ||
| @label="discourse_post_event.show_all" | ||
| @action={{this.showAllInvitees}} | ||
| /> |
There was a problem hiding this comment.
If this removal was intentional then showAllInvitees method should be deleted too
There was a problem hiding this comment.
Yes this was intentional, this button is now avail in the drop down ellipsis menu.
There was a problem hiding this comment.
will remove the method.
There was a problem hiding this comment.
now the component can be reduced to a template-only component, both service injections are unused and the properties could be inlined in the template 😃
There was a problem hiding this comment.
Would this still remain a gjs file? and only include while still using the imports like:
import icon from "discourse-common/helpers/d-icon";
import i18n from "discourse-common/helpers/i18n";
import Invitee from "./invitee";
There was a problem hiding this comment.
yup - still a gjs but without a js class:
const DiscoursePostEventInvitees = <template>
...
</template>
export default DiscoursePostEventInvitees;(btw, the new i18n import is: import { i18n } from "discourse-i18n";)
This PR adds a "going" count back into the events UI. The counts were removed previously to minimize the amount of information, but "going" should have remained.
After
Before
