Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to qunit best practices #665

Merged
merged 3 commits into from
Dec 17, 2024
Merged

updates to qunit best practices #665

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0375799
updates to qunit best practices
brrusselburg Dec 6, 2024
2845add
more q unit adjustments
brrusselburg Dec 17, 2024
19f172c
Update test/javascripts/integration/components/upcoming-events-list-t…
brrusselburg Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
182 changes: 89 additions & 93 deletions test/javascripts/integration/components/upcoming-events-list-test.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,7 @@ import { click, currentURL, render, waitFor } from "@ember/test-helpers";
import { module, test } from "qunit";
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
import pretender, { response } from "discourse/tests/helpers/create-pretender";
import {
exists,
fakeTime,
query,
queryAll,
} from "discourse/tests/helpers/qunit-helpers";
import { fakeTime, queryAll } from "discourse/tests/helpers/qunit-helpers";
import I18n from "discourse-i18n";
import UpcomingEventsList, {
DEFAULT_TIME_FORMAT,
Expand All @@ -30,21 +25,19 @@ const nextWeek = "2100-02-09T08:00:00";
module("Integration | Component | upcoming-events-list", function (hooks) {
setupRenderingTest(hooks);

let clock;

hooks.beforeEach(function () {
this.owner.unregister("service:router");
this.owner.register("service:router", RouterStub);

this.siteSettings.events_calendar_categories = "1";

this.appEvents = this.container.lookup("service:appEvents");
this.appEvents = this.owner.lookup("service:app-events");

clock = fakeTime(today, null, true);
this.clock = fakeTime(today, null, true);
});

hooks.afterEach(() => {
clock.restore();
hooks.afterEach(function () {
this.clock.restore();
});

test("empty state message", async function (assert) {
Expand All @@ -56,19 +49,21 @@ module("Integration | Component | upcoming-events-list", function (hooks) {

this.appEvents.trigger("page:changed", { url: "/" });

assert.strictEqual(
query(".upcoming-events-list__heading").innerText,
I18n.t("discourse_post_event.upcoming_events_list.title"),
"it displays the title"
);
assert
.dom(".upcoming-events-list__heading")
.hasText(
I18n.t("discourse_post_event.upcoming_events_list.title"),
"displays the title"
);

await waitFor(".loading-container .spinner", { count: 0 });

assert.strictEqual(
query(".upcoming-events-list__empty-message").innerText,
I18n.t("discourse_post_event.upcoming_events_list.empty"),
"it displays the empty list message"
);
assert
.dom(".upcoming-events-list__empty-message")
.hasText(
I18n.t("discourse_post_event.upcoming_events_list.empty"),
"displays the empty list message"
);
});

test("with events", async function (assert) {
Expand All @@ -78,11 +73,12 @@ module("Integration | Component | upcoming-events-list", function (hooks) {

this.appEvents.trigger("page:changed", { url: "/" });

assert.strictEqual(
query(".upcoming-events-list__heading").innerText,
I18n.t("discourse_post_event.upcoming_events_list.title"),
"it displays the title"
);
assert
.dom(".upcoming-events-list__heading")
.hasText(
I18n.t("discourse_post_event.upcoming_events_list.title"),
"displays the title"
);

await waitFor(".loading-container .spinner", { count: 0 });

Expand All @@ -94,15 +90,15 @@ module("Integration | Component | upcoming-events-list", function (hooks) {
moment(tomorrowAllDay).format("MMM").toUpperCase(),
moment(nextMonth).format("MMM").toUpperCase(),
],
"it displays the correct month"
"displays the correct month"
);

assert.deepEqual(
[...queryAll(".upcoming-events-list__event-date .day")].map(
(el) => el.innerText
),
[moment(tomorrowAllDay).format("D"), moment(nextMonth).format("D")],
"it displays the correct day"
"displays the correct day"
);

assert.deepEqual(
Expand All @@ -113,21 +109,20 @@ module("Integration | Component | upcoming-events-list", function (hooks) {
I18n.t("discourse_post_event.upcoming_events_list.all_day"),
moment(nextMonth).format(DEFAULT_TIME_FORMAT),
],
"it displays the formatted time"
"displays the formatted time"
);

assert.deepEqual(
[...queryAll(".upcoming-events-list__event-name")].map(
(el) => el.innerText
),
["Awesome Event", "Another Awesome Event"],
"it displays the event name"
"displays the event name"
);

assert.ok(
exists(".upcoming-events-list__view-all"),
"it displays the view-all link"
);
assert
.dom(".upcoming-events-list__view-all")
.exists("displays the view-all link");
});

test("with multi-day events, standard formats", async function (assert) {
Expand All @@ -154,7 +149,7 @@ module("Integration | Component | upcoming-events-list", function (hooks) {
"Awesome Multiday Event",
],

"it displays the multiday event on all scheduled dates"
"displays the multiday event on all scheduled dates"
);
});

Expand Down Expand Up @@ -191,7 +186,7 @@ module("Integration | Component | upcoming-events-list", function (hooks) {
.dom(".upcoming-events-list__heading")
.hasText(
"Upcoming events",
"it sets default value as the title in 'c/announcements'"
"sets default value as the title in 'c/announcements'"
);
});

Expand All @@ -204,11 +199,12 @@ module("Integration | Component | upcoming-events-list", function (hooks) {

await waitFor(".loading-container .spinner", { count: 0 });

assert.strictEqual(
query(".upcoming-events-list__view-all").innerText,
I18n.t("discourse_post_event.upcoming_events_list.view_all"),
"it displays the view-all link"
);
assert
.dom(".upcoming-events-list__view-all")
.hasText(
I18n.t("discourse_post_event.upcoming_events_list.view_all"),
"displays the view-all link"
);

await click(".upcoming-events-list__view-all");

Expand All @@ -228,11 +224,12 @@ module("Integration | Component | upcoming-events-list", function (hooks) {

this.appEvents.trigger("page:changed", { url: "/" });

assert.strictEqual(
query(".upcoming-events-list__heading").innerText,
I18n.t("discourse_post_event.upcoming_events_list.title"),
"it displays the title"
);
assert
.dom(".upcoming-events-list__heading")
.hasText(
I18n.t("discourse_post_event.upcoming_events_list.title"),
"displays the title"
);

await waitFor(".loading-container .spinner", { count: 0 });

Expand All @@ -244,15 +241,15 @@ module("Integration | Component | upcoming-events-list", function (hooks) {
I18n.t("discourse_post_event.upcoming_events_list.all_day"),
moment(nextMonth).format("LLL"),
],
"it displays the formatted time"
"displays the formatted time"
);

assert.deepEqual(
[...queryAll(".upcoming-events-list__event-name")].map(
(el) => el.innerText
),
["Awesome Event", "Another Awesome Event"],
"it displays the event name"
"displays the event name"
);
});

Expand All @@ -265,25 +262,28 @@ module("Integration | Component | upcoming-events-list", function (hooks) {

this.appEvents.trigger("page:changed", { url: "/" });

assert.strictEqual(
query(".upcoming-events-list__heading").innerText,
I18n.t("discourse_post_event.upcoming_events_list.title"),
"it displays the title"
);
assert
.dom(".upcoming-events-list__heading")
.hasText(
I18n.t("discourse_post_event.upcoming_events_list.title"),
"displays the title"
);

await waitFor(".loading-container .spinner", { count: 0 });

assert.strictEqual(
query(".upcoming-events-list__error-message").innerText,
I18n.t("discourse_post_event.upcoming_events_list.error"),
"it displays the error message"
);
assert
.dom(".upcoming-events-list__error-message")
.hasText(
I18n.t("discourse_post_event.upcoming_events_list.error"),
"displays the error message"
);

assert.strictEqual(
query(".upcoming-events-list__try-again").innerText,
I18n.t("discourse_post_event.upcoming_events_list.try_again"),
"it displays the try again button"
);
assert
.dom(".upcoming-events-list__try-again")
.hasText(
I18n.t("discourse_post_event.upcoming_events_list.try_again"),
"displays the try again button"
);
});

test("with events, overridden count parameter", async function (assert) {
Expand All @@ -295,27 +295,25 @@ module("Integration | Component | upcoming-events-list", function (hooks) {

this.appEvents.trigger("page:changed", { url: "/" });

assert.strictEqual(
query(".upcoming-events-list__heading").innerText,
I18n.t("discourse_post_event.upcoming_events_list.title"),
"it displays the title"
);
assert
.dom(".upcoming-events-list__heading")
.hasText(
I18n.t("discourse_post_event.upcoming_events_list.title"),
"displays the title"
);

await waitFor(".loading-container .spinner", { count: 0 });

assert.strictEqual(
queryAll(".upcoming-events-list__event").length,
1,
"it limits the resulting items to the count parameter"
);
assert
.dom(".upcoming-events-list__event")
.exists(
{ count: 1 },
"limits the resulting items to the count parameter"
);

assert.deepEqual(
[...queryAll(".upcoming-events-list__event-name")].map(
(el) => el.innerText
),
["Awesome Event"],
"it displays the event name"
);
assert
.dom(".upcoming-events-list__event-name")
.hasText("Awesome Event", "displays the event name");
});

test("with events, overridden upcomingDays parameter", async function (assert) {
Expand All @@ -329,19 +327,17 @@ module("Integration | Component | upcoming-events-list", function (hooks) {

await waitFor(".loading-container .spinner", { count: 0 });

assert.strictEqual(
queryAll(".upcoming-events-list__event").length,
1,
"it limits the results to started_at before the provided parameter"
);
assert
.dom(".upcoming-events-list__event")
.exists(
{ count: 1 },
1,
brrusselburg marked this conversation as resolved.
Show resolved Hide resolved
"limits the results to started_at before the provided parameter"
);

assert.deepEqual(
[...queryAll(".upcoming-events-list__event-name")].map(
(el) => el.innerText
),
["Awesome Event"],
"it displays the event name"
);
assert
.dom(".upcoming-events-list__event-name")
.hasText("Awesome Event", "displays the event name");
});
});

Expand Down
Loading