Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: recurring events not displayed on /upcoming-events #676

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

renato
Copy link
Contributor

@renato renato commented Jan 7, 2025

When we introduced the DiscoursePostEventEvent model and the API service, the recurrent events stopped working as their logic still relied on the old naming convention, upcoming_dates.

This PR changes the addRecurrentEvents logic to work with and to create DiscoursePostEventEvents for each of the upcomingDates, and changes the logic on the Category calendar to also work with the DiscoursePostEventEvent instance instead of the plain object, as well as re-using the API service to fetch the events.

The function passed to onPageChange was also changed to async/await with some minor changes for clarity.

@renato renato merged commit 3c833c9 into main Jan 8, 2025
6 checks passed
@renato renato deleted the fix_upcoming_dates_after_refactor branch January 8, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants