Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: schedule is un-necessary #681

Merged
merged 1 commit into from
Jan 21, 2025
Merged

DEV: schedule is un-necessary #681

merged 1 commit into from
Jan 21, 2025

Conversation

jjaffeux
Copy link
Contributor

As per CvX:

schedule("afterRender") inside next() is extraneous - next already schedules a separate run loop, so specifying that this code needs to run in the "afterRender" part of it shouldn't change anything

@jjaffeux
DEV: schedule is un-necessary
e6bafba 
As per CvX:

> schedule("afterRender") inside next() is extraneous - next already schedules a separate run loop, so specifying that this code needs to run in the "afterRender" part of it shouldn't change anything
@jjaffeux jjaffeux requested a review from CvX January 20, 2025 16:56
@jjaffeux
Copy link
Contributor Author

Seems like it's enough @CvX , feel free to merge directly

@CvX CvX merged commit cb4b6f6 into main Jan 21, 2025
6 checks passed
@CvX CvX deleted the schedule-not-necessary branch January 21, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CvX CvX CvX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjaffeux @CvX