Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Adding DATE casts to the Reactions dashboard report #235

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

TheJammiestDodger
Copy link
Contributor

@TheJammiestDodger TheJammiestDodger commented Sep 4, 2023

The Reactions dashboard report did not include data from the day of the end_date. Casting the respective created_at values as DATE should now include this.

/t/73842

The Reactions dashboard report did not include data from the day of the end_date. Casting the created_at values as DATE should now include this.
Copy link
Contributor

@nattsw nattsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged then write a test after 👍

@TheJammiestDodger TheJammiestDodger merged commit 3411bdd into main Sep 4, 2023
4 checks passed
@TheJammiestDodger TheJammiestDodger deleted the Reactions-Report-SQL-fix branch September 4, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants