-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SBT caching during code generation #1499
Improve SBT caching during code generation #1499
Conversation
e732967
to
70ebc75
Compare
modules/codegen-plugin/src/smithy4s/codegen/JsonConverters.scala
Outdated
Show resolved
Hide resolved
45f8628
to
4fcd2dd
Compare
modules/codegen-cli/src/smithy4s/codegen/cli/CodegenCommand.scala
Outdated
Show resolved
Hide resolved
Don't forget to sign the CLA |
Since it was requested in Mill's chat room, here is some input regarding Mill's cache. I have to admit, I didn't review the full PR and all comments, but from what I digested, here are my notes:
|
modules/codegen-plugin/src/smithy4s/codegen/Smithy4sCodegenPlugin.scala
Outdated
Show resolved
Hide resolved
modules/codegen-plugin/src/smithy4s/codegen/Smithy4sCodegenPlugin.scala
Outdated
Show resolved
Hide resolved
LGTM (@Baccata, you haven't committed here so I'll leave it for you to approve if, it looks OK now) |
Closes #1495.
@kubukoz's comment:
smithy4s/
prefix to generated paths undersrc_managed/main/scala
to avoid clashing with other codegens (in the default config for the generated code output)os.Path
), while inputs are still hashed based on contents (PathRef
)PR Checklist (not all items are relevant to all PRs)