Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for Product.Item calculations #146

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

madcalf
Copy link
Contributor

@madcalf madcalf commented Oct 2, 2024

What changed?

Adds tests for the custom calculations in the Product.Info content-type.
Also includes a few jest config changes.

Part of #145

How can you test this?

  1. Run yarn test (may need to run yarn test:with-build the first time if the strapi is defined test fails)
  2. Confirm all tests pass.

Prevents jest from adding stack trace info to console.log output
Non verbose mode only displays the test files being run and
summary of the results. But it's helpful to see the
individual tests being run within each test suite.
@madcalf madcalf force-pushed the test/tests-for-product-item-calculations branch from 56ca086 to a3848a3 Compare October 5, 2024 05:36
@madcalf madcalf changed the title test: add tests for `Product.Item calculations test: add tests for Product.Item calculations Oct 8, 2024
Copy link
Contributor

@veryeli veryeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great and reflects what we discussed well. Great job updating naming conventions!

@veryeli veryeli merged commit e87dad7 into saga Oct 14, 2024
1 check passed
@veryeli veryeli deleted the test/tests-for-product-item-calculations branch October 14, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants