Handle missing Opensearch indices #3584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBENCH-1308
An Opensearch-based query like `/api/v1/datasets/{dataset}/values/iterations`
requires that the `{dataset}` have at least one `result-data-sample` indexed
document. However it doesn't actually check that this is true. This leads to
an Opensearch query with a bad URL fragment causing an Opensearch error we
report as an internal server error.
This change detects early that the dataset has no indices for the required
index root name, and fails with a meaningful message.
webbnh
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1308
An Opensearch-based query like
/api/v1/datasets/{dataset}/values/iterationsrequires that the{dataset}have at least oneresult-data-sampleindexed document. However it doesn't actually check that this is true. This leads to an Opensearch query with a bad URL fragment causing an Opensearch error we report as an internal server error.This change detects early that the dataset has no indices for the required index root name, and fails with a meaningful message.