ogreetypes package #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeremWD
force-pushed
the
types
branch
2 times, most recently
from
f10ac98 to
b43e799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new package with the struct declarations that we need to get rid of all these ugly map[string]interface{}.
I was not very inspired for the name so I named it ogreetypes and I put it in a types/ folder, but you should make suggestions if you think it's not ideal.
The objects have their attributes at the root of the struct, and not in an subfield called "attributes", to make them easier to manipulate. However custom Marshalling and Unmarshaling functions are defined and are compatible with the current schemas.
Only two simple unit tests are defined for now, we will have to add them to the CI if the PR gets merged.
The new package is importable from CLI or API by adding the following lines to the go.mod file :
The PR does not change anything to the existing code, but at least we would have the types already defined, so that we can start refactoring on a common basis.