Updated router's setCollection to accept closure & route collection

divineniiquaye · Dec 7, 2022 · 8824413 · 8824413
1 parent ad62669
commit 8824413
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/Router.php b/src/Router.php
@@ -69,10 +69,11 @@ public function __construct(RouteCompilerInterface $compiler = null, string $cac
     /**
      * Set a route collection instance into Router in order to use addRoute method.
      *
+     * @param \Closure|RouteCollection|null $collection
      * @param null|string $cache file path to store compiled routes
      */
     public static function withCollection(
-        \Closure|RouteCollection $collection = null,
+        \Closure|RouteCollection|null $collection = null,
         RouteCompilerInterface $compiler = null,
         string $cache = null
     ): static {
@@ -157,11 +158,11 @@ public function pipes(string $name, MiddlewareInterface ...$middlewares): void
     /**
      * Sets the RouteCollection instance associated with this Router.
      *
-     * @param (callable(RouteCollection): void) $routeDefinitionCallback takes only one parameter of route collection
+     * @param \Closure|RouteCollection $collection
      */
-    public function setCollection(callable $routeDefinitionCallback): void
+    public function setCollection(\Closure|RouteCollection $collection): void
     {
-        $this->collection = $routeDefinitionCallback;
+        $this->collection = $collection;
     }
 
     /**