This repository has been archived by the owner on Apr 22, 2022. It is now read-only.
WIP: Run on kubernetes #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisgeus
reviewed
Sep 25, 2019
k8s/put-categories-deployment.yaml
Outdated
| volumes: | ||
| - name: divolte-shop | ||
| hostPath: | ||
| path: /Users/bas/code/gdd/shop |
| - name: SHOP_BANDIT_URL | ||
| value: http://toppick-bandit:8989/item | ||
| - name: SHOP_DIVOLTE_URL | ||
| value: //localhost:8290/divolte.js |
There was a problem hiding this comment.
I think localhost needs to be clickstream-collector
Sometimes a connection fails once. Then uploading the data will fail. Add a retry so that the uploading continues if simply a request failed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding the option to run the shop using Kubernetes. It is still WIP, and need more attention regarding documentation, clean up of service and deployment yaml files, improve the networking using Ingress? and cloud ready?