Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aggregator features #561

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Add aggregator features #561

merged 2 commits into from
Oct 13, 2023

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Oct 12, 2023

closes #560

@jbr jbr requested a review from a team as a code owner October 12, 2023 22:46
tgeoghegan
tgeoghegan approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@tgeoghegan tgeoghegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. None of the deployed aggregators currently managed by divviup-api have any features, so the database migration shouldn't need to assign any features to them.

@jbr jbr merged commit 7e7439d into main Oct 13, 2023
@jbr jbr deleted the add-features-array-to-config branch October 13, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgeoghegan tgeoghegan tgeoghegan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a features array to aggregator-api configuration struct, test for the presence of this TokenHash feature
2 participants
@jbr @tgeoghegan