Add token hash to collector credential #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbr
force-pushed
the
add-token-hash-to-collector-credential
branch
from
ee734b6 to
523e797
Compare
|
I'm currently testing this set of changes against |
|
I think this doesn't make sense to test yet, but my next pr actually provisions the aggregator with the token hash and would make sense to test. I can get that pushed shortly; the code is written and I can split the tests out into another commit |
|
Oh, whoops, I should have waited for the all-clear from you. Thanks! |
jbr
force-pushed
the
add-token-hash-to-collector-credential
branch
from
4f3c0d3 to
02bff89
Compare
jbr
force-pushed
the
add-token-hash-to-collector-credential
branch
from
02bff89 to
2f3d447
Compare
|
I'm going to merge this whole sequence; we can fix on main if there are discrepancies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #564
closes #566