Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check all targets when linting #608

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Check all targets when linting #608

merged 2 commits into from
Nov 1, 2023

Conversation

inahga
Copy link
Contributor

@inahga inahga commented Nov 1, 2023

No description provided.

jbr
jbr approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@jbr jbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How'd this come up? Do we have target conditional code somewhere?

@inahga
Copy link
Contributor Author

inahga commented Nov 1, 2023

cargo check and by extension clippy defaults to only checking library and binary targets https://doc.rust-lang.org/cargo/commands/cargo-check.html#target-selection. So tests are excluded by default. I discovered this because I on reflex run clippy with --all-targets because Janus' CI enforces it.

So all of the currently failing lints are going to be in tests.

@inahga inahga marked this pull request as ready for review November 1, 2023 18:30
@inahga inahga requested a review from a team as a code owner November 1, 2023 18:30
@jbr jbr merged commit 47a63a4 into main Nov 1, 2023
6 checks passed
@jbr jbr deleted the inahga/linting branch November 1, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbr jbr jbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inahga @jbr