docs: Prefer Arc::clone(&arc) instead of arc.clone() (#3380)

divviup · Aug 28, 2024 · b8c85cc · b8c85cc
1 parent 38a671d
commit b8c85cc
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/docs/DEVELOPMENT.md b/docs/DEVELOPMENT.md
@@ -125,4 +125,9 @@ To create a new migration:
         },
     ```
 
+* When using an `Arc`, prefer to write `Arc::clone(&arc)` instead of `arc.clone()`.
+  This makes it clear that the `Arc` is being cloned (cheap) and not the underlying
+  data type (possibly expensive). This will also catch any mistakes where you
+  intended to clone the Arc and not the underlying data.
+
 [hide_env_values]: https://docs.rs/clap/latest/clap/struct.Arg.html#method.hide_env_values