Replace "round" with "step" #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgeoghegan
added
the
allow-changed-migrations
When DAP-05 introduced the ping-pong topology, it also started talking about aggregation protocol "steps" instead of "rounds". This commit corrects the word usage across Janus to line up with the specification. Relevant to #1669
tgeoghegan
force-pushed
the
timg/round-to-step
branch
from
a79d187 to
16dd2e6
Compare
inahga
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Not pedantic at all, round meaning step is not obvious, bound to confuse future us or newcomers if not changed.
Uber nit: on messages/src/lib.rs:4565 the comment is // round. (Sorry, I don't think github lets you make a suggestion for code that isn't touched in a PR).
| @@ -448,7 +448,7 @@ async fn aggregation_job_mutation_report_aggregations() { | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn aggregation_job_init_two_round_vdaf_idempotence() { | |||
| async fn aggregation_job_init_two_step_vdaf_idempotence() { | |||
There was a problem hiding this comment.
We should probably keep this as-is. Poplar1 is two rounds, so this will still take one DAP step, just testing different code paths.
Suggested change
| async fn aggregation_job_init_two_step_vdaf_idempotence() { | |
| async fn aggregation_job_init_two_round_vdaf_idempotence() { |
Edit: nevermind, I got the conversion from rounds to steps wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When DAP-05 introduced the ping-pong topology, it also started talking about aggregation protocol "steps" instead of "rounds". This commit corrects the word usage across Janus to line up with the specification.
This change is pretty pedantic, but I think it's worth it for readers trying to resolve Janus against the DAP specification.
Relevant to #1669