Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comments #1928

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Update comments #1928

merged 2 commits into from
Sep 15, 2023

Conversation

divergentdave
Copy link
Collaborator

This makes a few small changes to comments.

  • Language around "steps" is changed slightly. Since the term is introduced in the DAP spec, and the steps are assigned numbers there, I think we shouldn't refer to them as "VDAF preparation steps". Moreover, one aggregation job step could encompass two VDAF preparation rounds.
  • Noted that the last_prep_resp column could also contain an encoded AggregationJobInitReq.
  • Since PrepareResp is a DAP message type, call it an "opaque DAP message" instead of an "opaque VDAF message".

@divergentdave divergentdave requested a review from a team as a code owner September 15, 2023 15:18
@divergentdave divergentdave added the allow-changed-migrations Override the ci-migrations check to allow migrations that have changed. label Sep 15, 2023
@divergentdave divergentdave merged commit 9763d26 into main Sep 15, 2023
@divergentdave divergentdave deleted the david/comment-fixups branch September 15, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@branlwyd branlwyd branlwyd approved these changes

@inahga inahga inahga approved these changes

Assignees
No one assigned
Labels
allow-changed-migrations Override the ci-migrations check to allow migrations that have changed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divergentdave @branlwyd @inahga