Add missing non_exhaustive to enums #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inahga
force-pushed
the
inahga/non-exhaustive
branch
from
cd6192f to
ca1d412
Compare
divergentdave
approved these changes
Sep 18, 2023
aggregator_api/src/routes.rs
Outdated
| @@ -321,7 +323,8 @@ pub(super) async fn put_global_hpke_config<C: Clock>( | |||
| req.kem_id.unwrap_or(HpkeKemId::X25519HkdfSha256), | |||
| req.kdf_id.unwrap_or(HpkeKdfId::HkdfSha256), | |||
| req.aead_id.unwrap_or(HpkeAeadId::Aes128Gcm), | |||
| ); | |||
| ) | |||
| .unwrap(); | |||
There was a problem hiding this comment.
We should propagate this error instead of unwrapping it, since the algorithms could be unsupported if the operator makes a mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly targeting the ExtensionType, but I noticed other enums that could expand in the future in this crate are missing it.
Adding it to the HPKE types comes with unfortunate propagation of an error and unwraps. I'm open to whether this change is worth it. We could also alternatively have a panic here https://github.com/divviup/janus/pull/1957/files#diff-9c7b948f33912f9d1847860795daa701030c35ed114ba5d7e1fcd9674f234ba2R219.