Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependabot automerge. #1966

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix dependabot automerge. #1966

merged 1 commit into from
Sep 20, 2023

Conversation

branlwyd
Copy link
Contributor

The important change is GITHUB_TOKEN -> GH_TOKEN. Despite the gh CLI allowing either, apparently in the context of Github Actions GITHUB_TOKEN is not allowed. (I couldn't find documentation to this effect, but the error I was receiving earlier suggested setting GH_TOKEN, and switching from GITHUB_TOKEN to GH_TOKEN does indeed cause the action to work as expected.)

The important change is GITHUB_TOKEN -> GH_TOKEN. Despite the gh CLI
allowing either, apparently in the context of Github Actions
GITHUB_TOKEN is not allowed. (I couldn't find documentation to this
effect, but the error I was receiving earlier suggested setting
GH_TOKEN, and switching from GITHUB_TOKEN to GH_TOKEN does indeed cause
the action to work as expected.)
@branlwyd branlwyd marked this pull request as ready for review September 20, 2023 19:44
@branlwyd branlwyd requested a review from a team as a code owner September 20, 2023 19:44
@branlwyd branlwyd enabled auto-merge (squash) September 20, 2023 19:46
@divergentdave
Copy link
Collaborator

LGTM. The docs say that GH_TOKEN takes precedence over GITHUB_TOKEN, so what's probably going on is that we're clobbering a GH_TOKEN environment variable set by GHA with the wrong user's token.

@branlwyd branlwyd merged commit 7bd91c3 into main Sep 20, 2023
@branlwyd branlwyd deleted the bran/automerge-dependabot branch September 20, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants