subscriber-01: Remove taskprov feature flag, always behave as if taskprov is enabled #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This environment will always operate with taskprov enabled. Make simplifications based on this assumption. We no longer have to consider cases where taskprov isn't enabled.
The main functionality change is that we always advertise a global HPKE key and not bother with the task key. Some tests are deleted based on this, the only operative test is
global_hpke_config().Notice that a lot of our tests still work as-is--many of them insert a task specific HPKE key and use it directly without roundtripping through the advertisement endpoint. This works since we still trial decrypt global keys and task-specific keys. However,
taskprov_tests.rsstill exercises the roundtrip, so there is coverage.This won't break janus-ops, since the extraneous config will be ignored (i.e. this doesn't block deployment).
In spirit of #1728.