break up janus_core::task
#1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inahga
approved these changes
Sep 25, 2023
core/src/vdaf.rs
Outdated
| BearerToken(URL_SAFE_NO_PAD.encode(rng.gen::<[u8; 16]>())) | ||
| } | ||
| } | ||
|
|
||
| /// Returns the given [`Url`], possibly modified to end with a slash. |
There was a problem hiding this comment.
I think we should hoist this to the top level of the crate, since it's not related to VDAFs at all.
Moves handling of authentication tokens to a new module `janus_core::auth_tokens`. Once that's gone, the only thing of substance left is `enum VdafInstance` and the macros for dispatching on VDAFs, so that module is renamed to `janus_core::vdaf` to better describe its purpose.
tgeoghegan
force-pushed
the
timg/move-auth-tokens
branch
from
06b3f3b to
e6ab04d
Compare
divergentdave
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves handling of authentication tokens to a new module
janus_core::auth_tokens. Once that's gone, the only thing of substance left isenum VdafInstanceand the macros for dispatching on VDAFs, so that module is renamed tojanus_core::vdafto better describe its purpose.