Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interop binaries: wait for database to be up #2006

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Interop binaries: wait for database to be up #2006

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e90f60b
Interop binaries: wait for database to be up
divergentdave Sep 26, 2023
66a0838
Add timeout
divergentdave Sep 26, 2023
cb37b6a
Exit on error
divergentdave Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions interop_binaries/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
#!/bin/bash
set -e

timeout 5m bash -c 'until pg_isready -U postgres; do sleep 1; done'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider running this script with set -e or perhaps better adding || "timeout waiting for postgres to be ready" && exit 1. Otherwise the script will fall through on failure.

This is a nit since we'll be able to see the results in the logs anyways, can take it or leave it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to resolve the issue with this change !
I have tested it in my local environment for both release/0.5 and 0.6.0-prerelease-1, and both passed successfully.

Thank you .

/usr/bin/supervisorctl -c /etc/janus/supervisord.conf start janus_interop_aggregator
/usr/bin/supervisorctl -c /etc/janus/supervisord.conf start aggregation_job_creator
/usr/bin/supervisorctl -c /etc/janus/supervisord.conf start aggregation_job_driver
Expand Down