Set a default log level in Dockerfile.interop_aggregator #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgeoghegan
approved these changes
Sep 28, 2023
divergentdave
deleted the
david/interop-aggregator-default-log-level
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2011 to set the default
RUST_LOGlevel in a Dockerfile environment variable. Docker allows environment variables declared in a container image to be overridden when creating a container, so the new code in #2011 will still be able to pass throughRUST_LOGfrom integration test processes. This change just affects other use cases of the images (such as in the divviup-ts test suite), so that they still get a good default amount of logging.