Task rewrite: use AggregatorTask in query_type
#2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgeoghegan
force-pushed
the
timg/new-task-datastore
branch
from
ea00c96 to
0bf9101
Compare
tgeoghegan
force-pushed
the
timg/new-task-query-type
branch
from
02e6358 to
6e60456
Compare
inahga
approved these changes
Sep 29, 2023
Adopts `janus_aggregator_core::task::AggregatorTask` in the `janus_aggregator_core::query_type` and `janus_aggregator::query_type` modules, making use of the routines for converting between `janus_aggregator_core::Task` and `janus_aggregator_core::AggregatorTask` to make this minimally intrusive. Part of #1524
tgeoghegan
force-pushed
the
timg/new-task-query-type
branch
from
3e7d66d to
0580256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #2017
Adopts
janus_aggregator_core::task::AggregatorTaskin thejanus_aggregator_core::query_typeandjanus_aggregator::query_typemodules, making use of the routines for converting betweenjanus_aggregator_core::Taskandjanus_aggregator_core::AggregatorTaskto make this minimally intrusive.Part of #1524