Task rewrite: Aggregator API #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inahga
approved these changes
Sep 29, 2023
tgeoghegan
force-pushed
the
timg/new-task-taskprov
branch
from
7224d51 to
913bf7e
Compare
tgeoghegan
force-pushed
the
timg/new-task-aggregator-api
branch
from
2d1e6c2 to
edc77cb
Compare
Adopt `janus_aggregator_core::task::AggregatorTask` throughout `janus_aggregator_api`. Gratifyingly, this removes some hacks that resolved impedance mismatches between the `PostTaskReq` and `janus_aggregator_core::task::Task`, which are no longer needed because `AggregatorTask` only has the peer aggregator's endpoint in it. Part of #1524
tgeoghegan
force-pushed
the
timg/new-task-aggregator-api
branch
from
edc77cb to
9c6baf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #2019
Adopt
janus_aggregator_core::task::AggregatorTaskthroughoutjanus_aggregator_api. Gratifyingly, this removes some hacks that resolved impedance mismatches between thePostTaskReqandjanus_aggregator_core::task::Task, which are no longer needed becauseAggregatorTaskonly has the peer aggregator's endpoint in it.Part of #1524