Differential Privacy Cleanups #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up a couple items as a follow-up to #1892. First, we close #1658 by removing the 64-bit variant of Prio3FixedPointBoundedL2VecSum. Due to length constraints, this could only be used on vectors with maximum dimension of three. Lower-precision variants will be more practically useful. Second, I removed the DP strategy generic type parameter from
compute_aggregate_share(), and relaxed the bound on the VDAF type parameter fromAggregatorWithNoisetoAggregator. This simplifies callsites and gets rid of some extra monomorphizations.