Fix infinite retry bug #2125
Merged
Fix infinite retry bug #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divergentdave
approved these changes
Oct 13, 2023
An infinite retry could be triggered if a report with the same ID as an expired report was ssubmitted.
It does somewhat matter what error we return here, because errors returned from this function are logged.
inahga
force-pushed
the
inahga/fix-runaway-retry-bug
branch
from
251193a to
f43b2ab
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An infinite retry could be triggered if a report with the same ID as an expired report was submitted.
Supports #2124.
I didn't add a separate method for
get_client_reports_including_expired_onesbecause naming things is hard, and I think this is the only situation where we care about expired reports.I altered the error message to provide more detail as to what's happening in this branch of code. The error here does matter because it is logged by
tracing.