release/0.5: adopt new divviup-api API
#2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PRs related to divviup/divviup-api#542 implement the new concept of "collector credential". This entails changes to the API for provisioning tasks via divviup-api that we use in e2e integration tests. On `release/0.5`, we don't use the `divviup-client` crate, so we update the client baked into Janus. Another curiosity is that while `divviup-api` will mint a collector auth token in response to our request to create a collector auth token, that auth token won't be used and instead the one generated by the Janus aggregator API gets plumbed back to us in the task creation request. Part of #2071
|
I empirically verified that we can run the Janus integration tests against a |
jbr
approved these changes
Oct 24, 2023
divergentdave
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PRs related to divviup/divviup-api#542 implement the new concept of "collector credential". This entails changes to the API for provisioning tasks via divviup-api that we use in e2e integration tests. On
release/0.5, we don't use thedivviup-clientcrate, so we update the client baked into Janus.Another curiosity is that while
divviup-apiwill mint a collector auth token in response to our request to create a collector auth token, that auth token won't be used and instead the one generated by the Janus aggregator API gets plumbed back to us in the task creation request.Part of #2071