Include batch details in batch mismatch error #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I think this extra information in JSON bodies would go against RFC 7807, as "extension members" are determined by the problem type definition, and DAP only defines the "task_id" extension member. It would be safe to template more information into the "detail" member. (It's possible this has changed in the more recent "problem details-bis" RFC, but I haven't looked over that yet, nor has DAP updated its reference.) |
|
Ah I think you're right--and this hasn't changed in RFC 9457. I will template the info into the |
inahga
force-pushed
the
inahga/batch-mismatch-error
branch
from
ca17875 to
7231945
Compare
tgeoghegan
approved these changes
Jan 23, 2024
inahga
force-pushed
the
inahga/batch-mismatch-error
branch
from
7231945 to
42431b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make investigation of a BatchMismatch error a bit easier, by propagating error information from the helper into the leader. This would be to mainly to spot trends in report counts or checksums.
This also comes with the happy extension of supporting arbitrary fields in a
ProblemDocumentand slightly more test coverage on the helper's checksum/report count calculation.