Abandon aggregation jobs early when a fatal error is encountered #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inahga
commented
Jan 16, 2024
Comment on lines
900
to
+903
| self: Arc<Self>, | ||
| datastore: Arc<Datastore<C>>, | ||
| maximum_attempts_before_failure: usize, | ||
| ) -> impl Fn(Lease<AcquiredAggregationJob>) -> BoxFuture<'static, Result<(), anyhow::Error>> | ||
| { | ||
| ) -> impl Fn(Lease<AcquiredAggregationJob>) -> BoxFuture<'static, Result<(), Error>> { |
There was a problem hiding this comment.
This function is basically the same as its collector counterpart, which makes it a candidate for hoisting out into the JobDriver, however I think it's just under the threshold where that refactor would be worth it, in terms of how much code needs to be touched.
branlwyd
approved these changes
Jan 16, 2024
inahga
force-pushed
the
inahga/abandon-aggregation-job-early
branch
from
5c7d014 to
11ed62f
Compare
inahga
force-pushed
the
inahga/abandon-aggregation-job-early
branch
from
11ed62f to
d2b6498
Compare
inahga
added a commit
that referenced
this pull request
Jan 22, 2024
* Abandon aggregation jobs early when a fatal error is encountered * Update aggregator/src/aggregator/aggregation_job_driver.rs Co-authored-by: Brandon Pitman <[email protected]> * Rebase pain --------- Co-authored-by: Brandon Pitman <[email protected]>
inahga
added a commit
that referenced
this pull request
Jan 23, 2024
* Abandon aggregation jobs early when a fatal error is encountered * Update aggregator/src/aggregator/aggregation_job_driver.rs Co-authored-by: Brandon Pitman <[email protected]> * Rebase pain --------- Co-authored-by: Brandon Pitman <[email protected]>
inahga
added a commit
that referenced
this pull request
Jan 23, 2024
…ease/0.6 backport #2502) (#2517) * Abandon aggregation jobs early when a fatal error is encountered (#2502) * Abandon aggregation jobs early when a fatal error is encountered * Update aggregator/src/aggregator/aggregation_job_driver.rs Co-authored-by: Brandon Pitman <[email protected]> * Rebase pain --------- Co-authored-by: Brandon Pitman <[email protected]> * Fix for 0.6 --------- Co-authored-by: Brandon Pitman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #235. Similar to #2476.
I've duplicated the
is_retryable_error()function because I strongly suspect that the interesting errors are going to differ between the two jobs.I've removed usage of
anyhow::Errorfrom the aggregation job driver. While we candowncast()ananyhow::Error, it seemed cleaner just to go ahead and use our fully fleshed outaggregator::Errorinstead.