Expose upload metrics through aggregator API #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branlwyd
approved these changes
Jan 24, 2024
tgeoghegan
approved these changes
Jan 24, 2024
inahga
force-pushed
the
inahga/metrics
branch
from
4316a4f to
37a3593
Compare
inahga
force-pushed
the
inahga/metrics-api
branch
from
ad7612f to
65bb165
Compare
inahga
added a commit
that referenced
this pull request
Jan 26, 2024
inahga
added a commit
that referenced
this pull request
Jan 26, 2024
inahga
added a commit
that referenced
this pull request
Feb 5, 2024
inahga
added a commit
that referenced
this pull request
Feb 5, 2024
* Add per-task report upload metrics (#2508) * Add per task report upload metrics. * Change default to 32, add documentation on option * Fix test * Build query instead of brute forcing each possible one * Don't wait on bad reports * Use Runtime and RuntimeManager instead of sleeping in tests * Clippy * Cargo doc * Don't use macro needlessly Co-authored-by: Brandon Pitman <[email protected]> --------- Co-authored-by: Brandon Pitman <[email protected]> * Expose upload metrics through aggregator API (#2537) * 0.6 specific fixes Don't change existing schema * Update schema version --------- Co-authored-by: Brandon Pitman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #2508.
I exposed these metrics through
tasks/{task_id}/metrics/uploads, rather than directly superseding or extending the existing/metricsendpoint.This is mostly for ease of backporting and compatibility with divviup-api. I also wanted to avoid coupling the queries that underly
/metricstogether, since currently it times out for large tasks. I also generally think multiple smaller APIs are better than a larger kitchen-sink one, since downstream can compose them any way it likes.