Message & request changes for async aggregation/collection. #3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #3436. Obviously this assertion is untested, but I think with this change Janus will now interoperate with a DAP-13 aggregator performing synchronous aggregation (possibly/likely modulo some pending |
divergentdave
approved these changes
Nov 27, 2024
Implementation of asynchronous aggregation is forthcoming. With this change, we use the Pending/Finished statuses for aggregation/collection as-specified, but both the Leader & Helper support only synchronous aggregation.
branlwyd
force-pushed
the
bran/async-agg-messages
branch
from
57b4a1c to
a034076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of asynchronous aggregation is forthcoming. With this change, we use the Pending/Finished statuses for aggregation/collection as-specified, but both the Leader & Helper support only synchronous aggregation.