Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

chore: Extract constants #54

Merged
merged 3 commits into from
Apr 17, 2024
Merged

chore: Extract constants #54

merged 3 commits into from
Apr 17, 2024

Conversation

dj8yfo
Copy link
Owner

@dj8yfo dj8yfo commented Apr 17, 2024 •
edited
Loading

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

@dj8yfo dj8yfo force-pushed the extract_constants branch from 855f834 to 53a0976 Compare April 17, 2024 20:07
@dj8yfo dj8yfo marked this pull request as ready for review April 17, 2024 20:14
@dj8yfo dj8yfo requested a review from frol April 17, 2024 20:14
frol
frol approved these changes Apr 17, 2024
View reviewed changes
Copy link

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we had more of these hardcoded lengths of the buffers than I expected. I went through the whole PR and it looks solid to me. I think it is worth merging it for future maintainability

@dj8yfo dj8yfo merged commit f3c7ec7 into develop Apr 17, 2024
25 of 26 checks passed
@dj8yfo dj8yfo deleted the extract_constants branch April 17, 2024 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frol frol frol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dj8yfo @frol