work on typing and linting errors

django_typer/__init__.py

@@ -23,7 +23,7 @@
 from django.core.management.base import BaseCommand
 from django.core.management.color import no_style
 from django.utils.functional import lazy
-from django.utils.translation import gettext_lazy as _
+from django.utils.translation import gettext as _
 from typer import Typer
 from typer.core import TyperCommand as CoreTyperCommand
 from typer.core import TyperGroup as CoreTyperGroup
@@ -87,7 +87,7 @@
 #     pass
 
 
-def traceback_config():
+def traceback_config() -> t.Union[bool, t.Dict[str, t.Any]]:
     """
     Fetch the rich traceback installation parameters from our settings. By default
     rich tracebacks are on with show_locals = True. If the config is set to False
@@ -99,7 +99,7 @@ def traceback_config():
     cfg = getattr(settings, "DT_RICH_TRACEBACK_CONFIG", {"show_locals": True})
     if cfg:
         return {"show_locals": True, **cfg}
-    return cfg
+    return bool(cfg)
 
 
 def get_command(

django_typer/apps.py

@@ -3,19 +3,25 @@
 installation logic.
 """
 import inspect
+import typing as t
+from types import ModuleType
 
 from django.apps import AppConfig
 from django.conf import settings
-from django.core.checks import Warning, register
-from django.utils.translation import gettext_lazy as _
+from django.core.checks import CheckMessage
+from django.core.checks import Warning as CheckWarning
+from django.core.checks import register
+from django.utils.translation import gettext as _
 
 from django_typer import traceback_config
 
+rich: t.Union[ModuleType, None] = None
+
 try:
     import rich
 
     tb_config = traceback_config()
-    if isinstance(tb_config, dict) and not tb_config.get("no_install", False):
+    if rich and isinstance(tb_config, dict) and not tb_config.get("no_install", False):
         # install rich tracebacks if we've been configured to do so (default)
         rich.traceback.install(
             **{
@@ -26,11 +32,11 @@
             }
         )
 except ImportError:
-    rich = None
+    pass
 
 
 @register("settings")
-def check_traceback_config(app_configs, **kwargs):
+def check_traceback_config(app_configs, **kwargs) -> t.List[CheckMessage]:
     """
     A system check that validates that the traceback config is valid and
     contains only the expected parameters.
@@ -47,7 +53,7 @@ def check_traceback_config(app_configs, **kwargs):
             unexpected = set(tb_cfg.keys()) - expected
             if unexpected:
                 warnings.append(
-                    Warning(
+                    CheckWarning(
                         "DT_RICH_TRACEBACK_CONFIG",
                         hint=_("Unexpected parameters encountered: {keys}.").format(
                             keys=", ".join(unexpected)

django_typer/completers.py

@@ -65,7 +65,7 @@ class ModelObjectCompleter:
     model_cls: t.Type[Model]
     lookup_field: str = "id"
     help_field: t.Optional[str] = None
-    query: QueryBuilder
+    query: MethodType
     limit: t.Optional[int] = 50
     case_insensitive: bool = True
     distinct: bool = True
@@ -87,9 +87,9 @@ def default_query(
         :raises TypeError: If there is a problem using the incomplete string as a
             lookup given the field class.
         """
-        field = self.model_cls._meta.get_field(
+        field = self.model_cls._meta.get_field(  # pylint: disable=protected-access
             self.lookup_field
-        )  # pylint: disable=protected-access
+        )
         if issubclass(field.__class__, IntegerField):
             return self.int_query(context, parameter, incomplete)
         if issubclass(field.__class__, (CharField, TextField)):
@@ -100,9 +100,7 @@ def default_query(
             return self.float_query(context, parameter, incomplete)
         raise ValueError(f"Unsupported lookup field class: {field.__class__.__name__}")
 
-    def int_query(  # pylint: disable=unused-argument
-        self, context: Context, parameter: Parameter, incomplete: str
-    ) -> Q:
+    def int_query(self, context: Context, parameter: Parameter, incomplete: str) -> Q:
         """
         The default completion query builder for integer fields. This method will
         return a Q object that will match any value that starts with the incomplete
@@ -127,9 +125,7 @@ def int_query(  # pylint: disable=unused-argument
             )
         return qry
 
-    def float_query(  # pylint: disable=unused-argument
-        self, context: Context, parameter: Parameter, incomplete: str
-    ) -> Q:
+    def float_query(self, context: Context, parameter: Parameter, incomplete: str) -> Q:
         """
         The default completion query builder for float fields. This method will
         return a Q object that will match any value that starts with the incomplete
@@ -152,9 +148,7 @@ def float_query(  # pylint: disable=unused-argument
             **{f"{self.lookup_field}__lt": upper}
         )
 
-    def text_query(  # pylint: disable=unused-argument
-        self, context: Context, parameter: Parameter, incomplete: str
-    ) -> Q:
+    def text_query(self, context: Context, parameter: Parameter, incomplete: str) -> Q:
         """
         The default completion query builder for text-based fields. This method will
         return a Q object that will match any value that starts with the incomplete
@@ -169,9 +163,7 @@ def text_query(  # pylint: disable=unused-argument
             return Q(**{f"{self.lookup_field}__istartswith": incomplete})
         return Q(**{f"{self.lookup_field}__startswith": incomplete})
 
-    def uuid_query(  # pylint: disable=unused-argument
-        self, context: Context, parameter: Parameter, incomplete: str
-    ) -> Q:
+    def uuid_query(self, context: Context, parameter: Parameter, incomplete: str) -> Q:
         """
         The default completion query builder for UUID fields. This method will
         return a Q object that will match any value that starts with the incomplete
@@ -265,7 +257,7 @@ def complete_app_label(ctx: Context, param: Parameter, incomplete: str):
     :return: A list of matching app labels. Labels already present for the parameter
         on the command line will be filtered out.
     """
-    present = [app.label for app in (ctx.params.get(param.name) or [])]
+    present = [app.label for app in (ctx.params.get(param.name or "") or [])]
     return [
         app.label
         for app in apps.get_app_configs()

django_typer/parsers.py

@@ -9,7 +9,7 @@
 from django.core.exceptions import ObjectDoesNotExist
 from django.core.management import CommandError
 from django.db.models import Model
-from django.utils.translation import gettext_lazy as _
+from django.utils.translation import gettext as _
 
 
 class ModelObjectParser:
@@ -61,15 +61,12 @@ def __call__(self, value: t.Union[str, Model]) -> Model:
             return self.model_cls.objects.get(**{self.lookup_field: value})
         except self.model_cls.DoesNotExist as err:
             if self.on_error:
-                self.on_error(self.model_cls, value, err)
-            else:
-                raise CommandError(
-                    _(
-                        '{model} "{value}" does not exist!'.format(
-                            model=self.model_cls.__name__, value=value
-                        )
-                    )
+                return self.on_error(self.model_cls, value, err)
+            raise CommandError(
+                _('{model} "{value}" does not exist!').format(
+                    model=self.model_cls.__name__, value=value
                 )
+            ) from err
 
 
 def parse_app_label(label: t.Union[str, AppConfig]):
@@ -85,14 +82,14 @@ def parse_app_label(label: t.Union[str, AppConfig]):
         return label
     try:
         return apps.get_app_config(label)
-    except LookupError:
+    except LookupError as err:
         label = label.lower()
         for cfg in apps.get_app_configs():
             if cfg.label.lower() == label:
                 return cfg
-            elif cfg.name.lower() == label:
+            if cfg.name.lower() == label:
                 return cfg
 
-    raise CommandError(
-        _("{label} does not match any installed app label.".format(label=label))
-    )
+        raise CommandError(
+            _("{label} does not match any installed app label.").format(label=label)
+        ) from err

pyproject.toml

@@ -113,6 +113,7 @@ DJANGO_SETTINGS_MODULE = "django_typer.tests.settings"
 python_files = "tests.py"
 norecursedirs = "*.egg .eggs dist build docs .tox .git __pycache__"
 
+
 addopts = [
   "--strict-markers",
   "--cov=django_typer",
@@ -140,3 +141,9 @@ max-args=30
 
 [tool.pylint.'MASTER']
 ignore="tests"
+
+[tool.pylint.'MESSAGES CONTROL']
+disable = [
+    'R0903',  # to few public methods - seriously?
+    'W0613', # unused argument - unavoidable in generic base interfaces
+]