Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.1 #154

Merged
Merged

Conversation

GitRon
Copy link
Contributor

@GitRon GitRon commented Feb 6, 2024

@justinmayer Does this seem correct to you for triggering a release?

@GitRon GitRon assigned GitRon and justinmayer and unassigned GitRon Feb 6, 2024
Copy link
Contributor

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done a poor job of explaining how AutoPub works, and for that I am very sorry. As noted in my comments below, AutoPub will automatically adjust the change-log and the __version__ value, so there's no need to manually edit these files. Adding a RELEASE.md with the expected format is all that is required.

As a side note, I took the liberty of cleaning up the change-log items, so feel free to copy-and-paste my suggested RELEASE.md contents in its entirety and made that the sole contents of this pull request.

Let me know if there is anything I can clarify. My sincere apologies for not explaining things better! 😅

@GitRon
Copy link
Contributor Author

GitRon commented Feb 6, 2024

Hi @justinmayer! Thx so much for your explanation! Maybe you could copy-paste your text to the docs/contribution of this project? So future-me can look it up and doesn't make a mess again 😅

Copy link
Contributor

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that an addendum to docs/contributing.txt containing release instructions would indeed be a useful thing to have 💯

Everything here seems to be in order. I suggest squash-merging this PR, after which we can watch the Rube Goldberg machine do its thing here in GitHub's Actions tab.

Please keep in mind that it's not uncommon for something to go awry the first couple of times, as sometimes there are one or two mis-configured parts of the process that need adjustment. The good news is that once it works successfully, it very rarely needs any further adjustment, and the efficiency dividends should continue to accrue for a good long while. 🌟

@GitRon GitRon merged commit ecb9c79 into django-crispy-forms:main Feb 6, 2024
7 checks passed
@GitRon GitRon deleted the maintenance/updated-changelog branch February 6, 2024 12:47
@GitRon
Copy link
Contributor Author

GitRon commented Feb 6, 2024

@justinmayer Squashed 🎉 Shall I create a new issue for the documentation part or are you going to do it without one?

@GitRon
Copy link
Contributor Author

GitRon commented Feb 6, 2024

Addition: The release failed 😅

@justinmayer
Copy link
Contributor

Yeah, I was monitoring the process in real time and saw that, too. I've never seen that particular error before, but I'm investigating it now.

Regarding the documentation addendum, please create a new issue for it, as I may not be able to get to that right away.

@GitRon
Copy link
Contributor Author

GitRon commented Feb 6, 2024

Awesome! Thx for your support!

@justinmayer
Copy link
Contributor

As suspected, there were a couple of wrinkles to iron out, but I got those sorted, and it seems the release was made successfully 🎉 https://github.com/django-crispy-forms/crispy-tailwind/releases/tag/1.0.1

@GitRon
Copy link
Contributor Author

GitRon commented Feb 7, 2024

Awesome! Thats really a big improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants