Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update field.html #165

Closed
wants to merge 1 commit into from
Closed

Conversation

IsraelBO17
Copy link

There's no use of the field_class variable that carries the 'mb-0' class. If there is, please explain

There's no use of the field_class variable that carries the 'mb-0' class.
If there is, please explain
@smithdc1
Copy link
Member

Thanks for the PR.

I'm slightly unsure what issue this aims to fix? It would be helpful if you could explain this.

Also please do run the test suite -- there's a number of errors shown with this change. We would need to be mindful of backward compatability.

@IsraelBO17
Copy link
Author

IsraelBO17 commented Apr 30, 2024 via email

@smithdc1
Copy link
Member

smithdc1 commented May 1, 2024

To make this type of customisation I recommend creating your own custom version of this template in your project.

You can then set the field_template attribute on your helper to use it throughoutyour project. See docs. https://django-crispy-forms.readthedocs.io/en/latest/form_helper.html#helper-attributes-you-can-set

@smithdc1
Copy link
Member

smithdc1 commented May 1, 2024

I'm not sure if there's a better way to handle this as an option. We get similar requests on the bootstrap5 pack.

However, just removing the margin isn't an acceptable solution as it seems to work for many situations.

@smithdc1 smithdc1 closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants