Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accepts empty values #353

Conversation

mitchelljkotler
Copy link
Contributor

When building the Solr document, empty values will not be skipped if
they are also present in the fieldUpdates. Tests are included.

@mitchelljkotler
Copy link
Contributor Author

Restyled is making substantial changes to parts of the code I did not touch. Travis CI seems stalled. Please let me know if any changes are needed to merge this PR in. Closes #261

When building the Solr document, empty values will not be skipped if
they are also present in the fieldUpdates.  Tests are included.
@mitchelljkotler mitchelljkotler force-pushed the 261-add-accept-empty-values-with-field-update branch from c84688b to 57afc5a Compare December 1, 2020 19:23
@mitchelljkotler
Copy link
Contributor Author

Any chance this can be reviewed and merged in?

@acdha acdha merged commit 57afc5a into django-haystack:master Jan 9, 2021
@acdha
Copy link
Collaborator

acdha commented Jan 9, 2021

Sorry about that. I just merged it.

@mitchelljkotler
Copy link
Contributor Author

mitchelljkotler commented Jan 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants